Skip to content

Address review feedback: fix stderr handling, validation, and editorconfig#14403

Draft
Copilot wants to merge 7 commits intomainfrom
copilot/sub-pr-14400
Draft

Address review feedback: fix stderr handling, validation, and editorconfig#14403
Copilot wants to merge 7 commits intomainfrom
copilot/sub-pr-14400

Conversation

Copy link
Contributor

Copilot AI commented Feb 9, 2026

Description

Addresses unresolved review comments from #14400:

  • .editorconfig: Removed root = true to inherit repo-level formatting rules (whitespace, charset). Follows pattern in tools/scripts/.editorconfig, playground/.editorconfig, src/Vendoring/.editorconfig.

  • Directory.Packages.props: Added comment explaining Hex1b.Tool is tracked for central version management despite only being referenced in .config/dotnet-tools.json.

  • CLI argument validation: Added bounds checks, replaced int.Parse with int.TryParse, validated positive values, surfaced friendly errors:

    $ dotnet MigratePackage.cs pkg 1.0.0 --poll-interval
    [ERROR] Missing value for --poll-interval. Expected a positive integer (seconds).
    
    $ dotnet MigratePackage.cs pkg 1.0.0 --poll-interval -5
    [ERROR] Invalid value for --poll-interval: '-5'. Expected a positive integer (seconds).
  • RunProcessAsync stderr handling: Read stdout/stderr concurrently to prevent deadlocks when child processes write large stderr output. Return stderr content on failure for diagnostics. Await tasks directly instead of Task.WhenAll + .Result.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Mitch Denny and others added 5 commits February 9, 2026 10:35
- SKILL.md: Agent instructions for version lookup, changelog review,
  user confirmation, and pipeline orchestration
- migrate-package.sh: Companion script to trigger and monitor the
  dotnet-migrate-package Azure DevOps pipeline (def 931)
- AGENTS.md: Register new skill in Available Skills section
Replace migrate-package.sh with MigratePackage.cs using:
- Azure.Identity (AzureCliCredential) for authentication
- Azure DevOps .NET SDK (PipelinesHttpClient) for pipeline
  triggering via RunPipelineAsync and polling via GetRunAsync
- Auto-detection of Microsoft corp tenant for token acquisition

Add .editorconfig and Directory.Packages.props overrides to
allow standalone #:package directives within the repo's CPM.
- Hex1b: 0.48.0 → 0.75.0
- Hex1b.McpServer: 0.48.0 → 0.75.0
- Hex1b.Tool: added at 0.75.0 (new dotnet tool)

All three packages imported via dotnet-migrate-package pipeline:
- Hex1b: Run 2898644 (succeeded)
- Hex1b.McpServer: Run 2898645 (succeeded)
- Hex1b.Tool: Run 2898650 (succeeded)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI and others added 2 commits February 9, 2026 05:17
…stderr

Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Hex1b packages to 0.75.0 and add Hex1b.Tool Address review feedback: fix stderr handling, validation, and editorconfig Feb 9, 2026
Copilot AI requested a review from mitchdenny February 9, 2026 05:19
Base automatically changed from dependency-update-skill to main February 9, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants